ccomeaux / boardgamegeek4android

BoardGameGeek application for Android (unofficial)
GNU General Public License v3.0
226 stars 47 forks source link

Broken link on Whitmore Score popup #163

Open rafal-watorski opened 2 years ago

rafal-watorski commented 2 years ago

It seems that the geeklist https://boardgamegeek.com/geeklist/37832/my-favorite-designers (link on the Whitmore Score popup) no longer exists.

Screenshot_2021-09-10-22-24-13-319_com boardgamegeek

Kaligula0 commented 2 years ago

Alternatives: 1) Internet Archive 2) a post in apps guild – "BGG for Android: What's a Whitmore Score?" 3) BGG for Android Users Manual with or withour anchor #toc23

Kaligula0 commented 2 years ago

The link is also in comments here https://github.com/ccomeaux/boardgamegeek4android/blob/develop/app/src/main/java/com/boardgamegeek/ui/GamePlayStatsFragment.kt#L640

Kaligula0 commented 2 years ago

This bug was filed already #143 and fixed 09ceb19065790099031279db55b2ba1ba503ae13 but not released yet.

However, what do you think of updating such links to the _BGG for Android Users Manual_ (link 3 above)?

rafal-watorski commented 2 years ago

I don't have a strong preference, but I would go with third option with anchor, so https://boardgamegeek.com/wiki/page/BGG_for_Android_Users_Manual#toc23

Kaligula0 commented 2 years ago

Filed a Pull request #165

Kaligula0 commented 2 years ago

ccomeaux merged PR #165

Kaligula0 commented 1 year ago

solved?

rafal-watorski commented 1 year ago

It's either not released yet or still not solved. I have the 6.8.2 (latest version) installed and the old link is still there.

Kaligula0 commented 1 year ago

I have the 6.8.2, too, but I cannot find the link in the app. So I checked the code here and 1) it's commented out, 2) the commit was before the release; so it made sense to me that it's released...

rafal-watorski commented 1 year ago

Open any game, then the "CREDITS" tab, then click on a designer and go to the "STATS" tab. Click on the "Whitmore Score".

Kaligula0 commented 1 year ago

Oh, there! You're right, there still it is.