Login stopped working

[rafal-watorski]

BGG changed the login POST a little bit, so it stopped working in the app. It seems that only a small change is needed in the NetworkAuthenticator.java in buildRequest function.

• url changed from "https://www.boardgamegeek.com/login" to "https://boardgamegeek.com/login/api/v1"
• contentType changed from application/x-www-form-urlencoded to application/json
• payload is not longer a FormBody, but a JSON with following structure:

  {
  "credentials": {
      "username": "XXXXXXXX",
      "password": "YYYYYYYY"
  }
  }

[tvedeane]

Hey,

Thanks for reporting, preparing a fix for that.

PR can be found here.

[rafal-watorski]

I'm not sure why BGG used response code 202 instead of simply 200 in this case. It's quite confusing, because 202 was usually used when XMLAPI/XMLAPI2 requests were accepted for processing and you needed to request the data later...

[tvedeane]

Fixed in https://github.com/ccomeaux/boardgamegeek4android/pull/167.

[cmadamsgit]

Any chance of getting a new release with this fix included? I have a new device and can't log in with this app because of this.

[tvedeane]

Good point, we could get a new release (a RC, I guess), but we would need help from @ccomeaux because I never did it before in this repository, so I'm not sure if this should happen from develop branch and how to name it.

[ccomeaux]

I have they key to make sure the APK matches the previous one to allow for an upgrade instead of a new application install. That said, I've got an RC set to go, I just need to give it a test. Sorry it's taken so long, but over the last year, lots of small things no longer worked.

I will release something from the develop branch soon, but there have been so many changes that I didn't feel comfortable try to hot fix for the login.

[Kaligula0]

You can also release a beta if you would like some of us to test the changes ;)

[ccomeaux]

Just created a release if you wanted to give it a spin. https://github.com/ccomeaux/boardgamegeek4android/releases/tag/6.8.1

[cmadamsgit]

Thanks, that's got my new phone logged in!

[tvedeane]

Also works on my device!

[Kaligula0]

Works on Xperia XZ1C Android 9, too! ♥ Thanks