search

ccomeaux / boardgamegeek4android

BoardGameGeek application for Android (unofficial)
GNU General Public License v3.0
226 stars 47 forks source link

Added GitHub actions to build on PR and push #173

Closed Malivil closed 2 years ago

Malivil commented 2 years ago

This doesn't tag or push a release but it will auto-build any pull request and also post-push to any branch.

It requires creating a repository secret (https://github.com/ccomeaux/boardgamegeek4android/settings/secrets/actions) named GOOGLE_SERVICES_JSON which contains the full JSON of the google-services.json file.

The build also currently does not succeed due to linting errors but I didn't want to make any changes to the project other than to add the build.

Changes to the gradlew files are to give them execute permissions which is required for the actions build.

ccomeaux commented 2 years ago

@Malivil - I tried this, but I couldn't get it to work. When reading the secret it tells me the JSON is malformed, but I'm sure the JSON is valid, so I think there's some other issue at play. Any ideas?

Malivil commented 2 years ago

@Malivil - I tried this, but I couldn't get it to work. When reading the secret it tells me the JSON is malformed, but I'm sure the JSON is valid, so I think there's some other issue at play. Any ideas?

Honestly i haven't looked at this since i submitted the PR so I don't really remember. I just remember putting the full file contents in that field and then it worked. I saw some of your debugging attempts (printing out thy file and stuff) which is what i would have suggested trying so not sure what else to do. This is the only time I've used GitHub actions or gradle so I'm not much help, sorry