search

ccomeaux / boardgamegeek4android

BoardGameGeek application for Android (unofficial)
GNU General Public License v3.0
228 stars 47 forks source link

App crashes when trying to edit a play comment. #85

Closed tOverney closed 6 years ago

tOverney commented 6 years ago

App version: 6.5.5 Android version: 8.0.0

Phone tested on: Nexus 5X & Nexus 6P (same versions for both phones)

Open a logged play, click the pencil icon, clic somewhere in the comment and the app crashes.

tupaschoal commented 6 years ago

I don't see this error on the same App version, but older Android (5.0.2), so it might be related to Oreo itself.

On Sat, 14 Oct 2017 at 10:20 Tristan Overney notifications@github.com wrote:

App version: 6.5.5 Android version: 8.0.0

Phone tested on: Nexus 5X & Nexus 6P (same versions for both phones)

Open a logged play, click the pencil icon, clic somewhere in the comment and the app crashes.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ccomeaux/boardgamegeek4android/issues/85, or mute the thread https://github.com/notifications/unsubscribe-auth/AGJRowx9puGKXzE0jlUxVSYpX-ZODM1Qks5ssLU1gaJpZM4P5YOT .

ccomeaux commented 6 years ago

This is a problem with the focus logic in Oreo. I fixed a similar issue in https://github.com/ccomeaux/boardgamegeek4android/commit/499af4d34b3e0489691e8888572ea5d1c03ef6ae . Since this activity is so configurable and the error so indirect, it might be difficult to narrow down the source. Last time it was some views allowing focus that shouldn't have.

ccomeaux commented 6 years ago

This was hopefully fixed in the latest hotfix (6.5.6). Please let me know if it's working for you now. Thanks.

tOverney commented 6 years ago

Sadly no, I've just tested it and if I click the edit button and then click the comment, it still crashes.

Strangely enough if I first click on a player name, then cancel out and then click on the play's comment it works.

But without first opening the "player edit" activity it still crashes.

ccomeaux commented 6 years ago

@tOverney, can you include a screen shot of the play before it crashes. I can't duplicate it, so I want to be sure I have all of the right fields populated. Thanks!

tOverney commented 6 years ago

Attached is one play that crashes but every single plays with comments that I've tried fails :)

Again if I click any fields first (even location) it doesn't crash, it only seems to be when I first try to click the comment.

My app version is 5.6.5 and the update happened 2 days ago, should there be something more recent?

Lastly I've also tested it on my SO's Nexus 5X and it also crashes.

problematic play

ccomeaux commented 6 years ago

I'm sure you must have a typo in the version. The latest is 6.5.6 - I don't think there was ever a 5.6.5. Please confirm.

Also, what version of Android is your SO'd phone running?

I'm unable to duplicate the issue, so the more info I have the better. Thanks!

tOverney commented 6 years ago

Yes sorry :/ 6.5.6! As said in the inital post we both have Android 8.0.0 with the security patch of October 5th on both phones.

tOverney commented 6 years ago

I've crashed the app three times on different plays and sent feedback with system logs included. (Comment is "PR #85") I can also provide you with the logcats of the crash but That has to wait until I have my computer (next Monday)

tOverney commented 6 years ago

This is now fixed! Thank you again @ccomeaux !