Loading state displays on top of search screen content

[kamal-kamalmohamed]

While searching for a game the loading state displays on top of the list content.

Scenario 1: Steps:

• Open app
• Tap on search
• Type any combination of characters
• Observe

Expected:

• The loading state doesn't overlap the text

Actual:

• The loading state overlaps the text

Scenario 2: Steps:

• Open app
• Tap on search
• Search for any game
• Wait for list results
• Type one more character
• Observe

Expected:

• The loading state doesn't overlap the list results

Actual:

• The loading state overlaps the list results

Reported on Android 8.0. Attached screenshots.

In terms of how to fix this I would suggest an horizontal loading state at the top of search results instead of having a full screen one. I'll put together a PR if that's alright.

[kamal-kamalmohamed]

@ccomeaux Happy with the suggested approach of having an horizontal progress bar just below the search bar? Happy to submit a PR for it. 😄

[ccomeaux]

The progress bar is working as intended, but I'm not sure my intention is better than your suggestion. So fire away!

[kamal-kamalmohamed]

Raised PR here: https://github.com/ccomeaux/boardgamegeek4android/pull/92

[ccomeaux]

Will be in next minor release