search

cconard96 / glpi-screenshot-plugin

Take a screenshot or screen recording directly from GLPI and attach it to a ticket, change or problem
GNU General Public License v2.0
5 stars 0 forks source link

Cannot update to version 1.1.5 #26

Closed jackburton79 closed 2 years ago

jackburton79 commented 2 years ago

Hi, Cannot update to latest version from marketplace. I think the release process failed like last time.

cconard96 commented 2 years ago

It did fail again but I manually created the archive before publishing the release. I tested the download link in the plugin XML and it works. Are there any errors from the marketplace?

cconard96 commented 2 years ago

Please try updating from the marketplace again. Should be fixed now.

jackburton79 commented 2 years ago

Still same error: Uncaught Exception PharException: Extraction from phar "/usr/local/share/glpi/files/_tmp/glpi-screenshot-v1.1.6.tar.bz2" failed: Cannot extract "", internal error in /usr/local/share/glpi/vendor/wapmorgan/unified-archive/src/Formats/Tar.php at line 513

jackburton79 commented 2 years ago

File is correctly downloaded in the tmp directory, and it seems to be correct:

group:/usr/local/share/glpi/files/_tmp # tar -tjf glpi-screenshot-v1.1.6.tar.bz2 screenshot/locales/pt_PT.mo screenshot/CHANGELOG.md screenshot/tools/extract_template.sh screenshot/locales/en_GB.po screenshot/ajax/config.php screenshot/locales/pt_BR.po screenshot/locales/es_ES.po screenshot/hook.php screenshot/locales/en_US.po screenshot/locales/ screenshot/locales/pt_PT.po screenshot/locales/fr_FR.mo screenshot/ screenshot/ajax/ screenshot/screenshot.xml screenshot/tools/ screenshot/inc/migration.class.php screenshot/locales/ru_RU.mo screenshot/js/ screenshot/inc/config.class.php screenshot/ajax/screenshot.php screenshot/README.md screenshot/inc/ screenshot/locales/en_GB.mo screenshot/locales/fr_FR.po tar: Removing leading `/' from member names / screenshot/.devplugin screenshot/locales/pt_BR.mo screenshot/locales/screenshot.pot screenshot/locales/es_ES.mo screenshot/inc/profile.class.php screenshot/inc/screenshot.class.php screenshot/locales/en_US.mo screenshot/LICENSE screenshot/setup.php screenshot/js/screenshot.js screenshot/locales/ru_RU.po

cconard96 commented 2 years ago

The only thing I can think of is the issue is with me changing it from a zip archive to a tar.bz2. Do you have the bzip PHP extension installed?

jackburton79 commented 2 years ago

It seems it's installed: i | php7-bz2 | bzip2 codec support for PHP

jackburton79 commented 2 years ago

and GLPI says: bz2 extension is installed

cconard96 commented 2 years ago

I repackaged the archive. It looks like there was a bad file in the original. I had taken the empty archive it made and just manually added the files but I guess it wasn't really empty even when nothing showed in the GUI. Apparently the action that creates releases hates this plugin. It works for every other plugin I've used it with without issues yet.

Can you try installing it again?

jackburton79 commented 2 years ago

Thanks! It worked fine now.