search

cconard96 / glpi-screenshot-plugin

Take a screenshot or screen recording directly from GLPI and attach it to a ticket, change or problem
GNU General Public License v2.0
5 stars 0 forks source link

Possible bug between formcreator and screenshot #40

Closed rafacss closed 1 year ago

rafacss commented 1 year ago

Recently a form from formcreator had problems. the send button disappears. when I disable the screenshot plugin it reappears.

More details can be seen here: https://github.com/pluginsGLPI/formcreator/issues/3064

https://user-images.githubusercontent.com/67194670/202818496-8f4933cc-a16e-40ea-b38b-02e1358026bd.mp4

cconard96 commented 1 year ago

It doesn't make sense that this plugin would be using the CSRF token at all here as suggested was the issue in the form creator issue. The plugin would only be getting its config via a GET request which shouldn't check the token.

It may be unrelated, but the screenshot plugin should probably not care (or at least not cause a potential failure) if there is a user logged in when getting the config. In "plugins/screenshot/ajax/config.php", can you try commenting out the Session::checkLoginUser(); line and see if that resolves the issue with form creator when this plugin is enabled?

rafacss commented 1 year ago

Thanks for the answer!

I will perform the test you suggested and come back with news here.

I forwarded your answer to the issue reported in the formcreator thread

rafacss commented 1 year ago

with the screenshot plugin active, I commented out the line Session::checkLoginUser(); and after saving the send button reappeared even with the active screenshot plugin.

image

Would you like me to perform some new test?

I'm using GLPI 10.0.5 and Screenshot 2.0.1 plugin

cconard96 commented 1 year ago

Should be fixed by v2.0.2 of this plugin

rafacss commented 1 year ago

issue fixed in released version of screenshot 2.0.2