cconard96 / jamf

JAMF Plugin for GLPI
GNU General Public License v2.0
6 stars 5 forks source link

Jamf Import missing field #115

Closed bacus99 closed 1 year ago

bacus99 commented 2 years ago

With version 3.0.1, when sync

2022-08-12 08:07:12] glpisqllog.ERROR: DBmysql::query() in /usr/share/glpi/src/DBmysql.php line 370 MySQL query error: SQL: SELECT FROM glpi_plugin_jamf_extensionattributes WHERE jamf_id = '54' AND itemtype = 'PluginJamfComputer' AND jamf_type = 'Computer' LIMIT 1 Error: Unknown column 'itemtype' in 'where clause' Backtrace : src/DBmysqlIterator.php:110
src/DBmysql.php:1048 DBmysqlIterator->execute() src/CommonDBTM.php:573 DBmysql->request() marketplace/jamf/inc/computersync.class.php:292 CommonDBTM->find() marketplace/jamf/inc/devicesync.class.php:248 PluginJamfComputerSync->syncExtensionAttributes() marketplace/jamf/inc/computersync.class.php:663 PluginJamfDeviceSync::sync() marketplace/jamf/inc/computersync.class.php:557 PluginJamfComputerSync::import() marketplace/jamf/inc/cron.class.php:56 PluginJamfComputerSync::discover() src/CronTask.php:1018 PluginJamfCron::cronImportJamf() marketplace/jamf/ajax/cron.php:50
CronTask::launch()**

Needed to add a new column in glpi_plugin_jamf_extensionattributes named itemtype varchar 50

cconard96 commented 2 years ago

I think I caught this issue while reworking the code tests. It should be fixed by c21c089a250d6dc0757f3c4eef0fb4c46aa1944b The field that was missing shouldn't be needed, but it was mistakenly put or left in a database query.

bacus99 commented 2 years ago

Looks good, only itemtype default NULL and it's OK

FlorentDerangere commented 1 year ago

Looks good, only itemtype default NULL and it's OK

Hello what have you do to fix that issue ?

bacus99 commented 1 year ago

Bonjour Florent,

Vous pouvez changer le script d’installation ou changer la table directement dans MySQL

Je ne me souviens plus des champs par coeur

Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows

From: @.> Sent: July 17, 2023 5:37 AM To: @.> Cc: Christian @.>; @.> Subject: Re: [cconard96/jamf] Jamf Import missing field (Issue #115)

Looks good, only itemtype default NULL and it's OK

Hello what have you do to fix that issue ?

— Reply to this email directly, view it on GitHubhttps://github.com/cconard96/jamf/issues/115#issuecomment-1637697687, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACXFLWIBPL2UWPTPJGYJZE3XQUBUPANCNFSM56LRJKXQ. You are receiving this because you authored the thread.Message ID: @.***>