search

cconroy20 / fsps

Flexible Stellar Population Synthesis
MIT License
84 stars 48 forks source link

maxtime in compsp #3

Closed nell-byler closed 3 years ago

nell-byler commented 8 years ago

Ran into an issue when trying to generate CSPs using the Geneva isochrones. The Geneva isochrones only go up to 100 Myr (logt=8.0), which generates an error at line 549 in compsp.f90

  IF (maxtime.LE.1E8.AND.pset%sfh.NE.0) THEN
     WRITE(*,*) 'COMPSP ERROR, maxtime too small:',maxtime
     STOP
  ENDIF

I ran into this error when trying to generate populations with constant star formation histories; the maximum age in the Geneva isochrones being 1E8 meant that I got an error when trying to calculate any CSP.

Geneva isochrones aside, does this mean that it isn't possible to generate populations with constant star formation over anything less than 100 Myr? (i.e. trying to return a spectrum with tage anything less than 100 Myr would always raise this error regardless of the isochrone being used).

moustakas commented 7 years ago

I think this was fixed in #26.

bd-j commented 7 years ago

yes, this was fixed by #26 and can be closed. This warning was a holdover from the old-style approximations to the convolution of the SFH with the SSPs, which has now been replaced with a more accurate method.