search

cconroy20 / fsps

Flexible Stellar Population Synthesis
MIT License
85 stars 48 forks source link

Fix mweights #58

Closed bd-j closed 2 years ago

bd-j commented 2 years ago

Work in Progress/Do not merge

This PR has a some updates intended to fix the computation of formed mass for tabular SFHs, and expose the SSP weights from csp_gen in the common module (e.g. for access via python-FSPS). Also some cleanup of parameter checking and unused variables.

Needs some testing, and there might be a cleaner way to expose the ssp weights (e.g. as an output array of csp_gen and compsp)

bd-j commented 2 years ago

I've done some testing and I think this works both to expose the SFH weights and to fix the formed mass for tabular SFH. There's still the imf_lower_limit bug to fix, but I think this is ready to merge.