search

ccontavalli / grub-shusher

Makes grub's boot quiet, with no need for recompiling or patching the source code.
Other
54 stars 7 forks source link

Added GPT support #1

Closed Cyberboss closed 7 years ago

Cyberboss commented 9 years ago

Only one of the matches is found in the boot track when grub is installed to a gpt disk, two of them are found in a secondary ef02 partition. This pull will enable mbr to patch them out if it is run with the -g flag. It requires it to be run on both the main disk and the ef02 partition for full silencing.

ccontavalli commented 9 years ago

Hello, sorry for delay, I am currently traveling and don't have enough internet time to do anything useful.

I'd really like to add GPT support, so I'm really excited about the pull request! Hopefully I will be able to merge this in over the next few days or early next week at the latest. Need to also update the READEM.md accordingly.

Thanks, Carlo

ccontavalli commented 9 years ago

Ok, so I have merged in your GPT changes and updated the README file. Please have a look, and let me know if the instructions are correct.

I just saw all the other changes in your branch. Not to be pedantic, but you are not permitted to remove the LICENSE file and redistribute the code for as long as some of the original code is retained.

To quote the existing license:

""" Redistribution and use in source and binary forms, with or without modification, are permitted provided that the following conditions are met:

  1. Redistributions of source code must retain the above copyright notice, this list of conditions and the following disclaimer. ... """

That apart, I see you added: 1) files to build shusher on ARCH 2) changes to use autoconf and friends 3) switch to c++ compiler

I'd be happy to include 1) in my own branch, is that ok?

2), is there any specific reason this is necessary? Any specific issue it is solving? Eg, there are very few architectures / systems where shusher is useful, so far I believed a simple makefile was enough :), but may be wrong here.

3) the changes are minimal, had to make similar (same?) changes as soon as I enabled -pedantic and -Wall flags. With that in mind, not sure why it was done? Planning for future changes?

Thanks again for the contributions, Carlo

Cyberboss commented 9 years ago

Sorry about the license thing, I'm not familiar with the GPL. I'll add it back. And for sure you can include everything in your own branch. The autoconf stuff was me messing around, as this is mainly a side project for me. The port to c++ is a personal thing. The main features I eventually will add was automatic GPT partition detection like grub is able to do when it installs and a wrapper grub to make the process a one command stop.