search

ccontavalli / ssh-ident

Different agents and different keys for different projects, with ssh.
Other
963 stars 71 forks source link

[Feature request]: Add PKCS11 support #45

Open lhernanz opened 6 years ago

lhernanz commented 6 years ago

I would like to add PCSK11 support to ssh-agent so that some keys can be retrieved from a HW token for enhanced security. I already have a prototype running in my machine, but I would like to gather some feedback before doing the pull request.

ccontavalli commented 6 years ago

Hello! Before anything else, thank you for reaching out.

Adding PCSK11 support sounds great to me in general. If you could point me to a working version of the code, I can try to have a look, and see if we can integrate as is, or propose changes or improvements.

lhernanz commented 6 years ago

You are welcome! Please, find the code here. If you like how it looks, I can open a PR and we can start collaborating in getting it in shape to be merged. I have added some instructions to the code and README file.

lhernanz commented 6 years ago

Hi @ccontavalli, did you have the opportunity of looking at the code? Thanks

lhernanz commented 6 years ago

Hi @ccontavalli, did you have the opportunity of looking at the code? If you are not interested at looking at the code, I might go ahead an release it in my fork. I have been using the code for months and it works quite well. It would be a pity not to make it more accessible to everybody. Thanks