Valenoroi stops "painting" the map

ccoors / Valeronoi

A WiFi mapping companion app for Valetudo

GNU General Public License v3.0

352 stars 12 forks source link

Valenoroi stops "painting" the map #11

Open seppeel opened 3 years ago

seppeel commented 3 years ago

I own a Roborock S5 Max rooted and running with Valetudo 2021.03.0. When i start Cleaning and Valenoroi Recording -> Everything looks fine and the Map is starting to get "painted". But after something between 1500 and 2000 Measurements the map stops getting painted. I see the "Measurement" and "Unique Places" Counters increasing. The "Lastest Signal" is changing to the (i would say) correct value. Is there something like an upper limit for Measurements Valenoroi is able to "paint"? I did this two times, it was always the same result.

grafik

ccoors commented 3 years ago

That´s weird. I want to take a look at the raw data. Can you save and attach the file from Valeronoi? Or send it by Mail/Telegram, if you´re not comfortable sharing it on GitHub.

seppeel commented 3 years ago

Sure, i now stopped the Recording while cleaning in progress and saved as git.vwm git.zip

ccoors commented 3 years ago

When I load that file in Valeronoi it looks like this (which I´d say looks fine):

Did you enable OpenGL?

seppeel commented 3 years ago

Very weird. I closed valenoroi and loaded the file again. Then it looks good (like your screenshot). OpenGL was disabled. Then the issues is not "Valenoroi stops painting", its "Valenoroi stops showing that its painting" :D For me its OK as when i know, that the data is not lost as long as i just continue recording and then have to "reload the data".

ccoors commented 3 years ago

Indeed. Sorry for the inconvenience, I can´t really reproduce it myself because my apartment is quite small :) I´ll have to wait until Valetudo supports virtual maps in MockRobot.

seppeel commented 3 years ago

let me know if i can provide anything to help. thanks for your work.

ccoors commented 3 years ago

I just released Valeronoi 0.1.3 with a new logging window (Help -> Log). If you get the chance, could you try it again?

Does the log continue to print "Requesting generation of Voronoi segments" and "Calculated new Voronoi segments" when the painting stops?

This will help narrow the issue down. The Voronoi diagram calculation is done in a separate thread because it's quite expensive. I suspect the thread just hangs after some time. If no more "Calculated new Voronoi segments" appear, that's the case.

seppeel commented 3 years ago

I will deliver some information as soon as our house looks like it needs some robo cleaning ;-)

albpara commented 3 years ago

Has similar issues with two different maps today, haven't saved anything that could provide help apart form the attached image. I will try to reproduce the problem again:

1stfloor

seppeel commented 3 years ago

I was not able to reproduce it after updating to 0.1.3 with the last cleaning.

winebob commented 3 years ago

Having a similar issue here. I watched for a while live when it was near the dock and it was painting correctly. Came back at the end and there was almost no color showing. Saved, reloaded, and it looks like this:

Upper Floor.zip