Open wernst opened 6 months ago
Was looking through the codebase and saw that transactionalReadAsync is using a sync retry (and potentially not awaiting the async tx.commit call). Should that be async?
transactionalReadAsync
tx.commit
If so happy to put out a quick PR.
Line for reference: https://github.com/ccorcos/tuple-database/blob/aa18612e57fe4946df99866e7f3e7bf40cbe87b8/src/database/async/transactionalReadAsync.ts#L26
absolutely a bug!
ccorcos
commented
6 months ago
Was looking through the codebase and saw that
transactionalReadAsyncis using a sync retry (and potentially not awaiting the asynctx.commitcall). Should that be async?If so happy to put out a quick PR.
Line for reference: https://github.com/ccorcos/tuple-database/blob/aa18612e57fe4946df99866e7f3e7bf40cbe87b8/src/database/async/transactionalReadAsync.ts#L26