search

ccoreilly / vosk-browser

A speech recognition library running in the browser thanks to a WebAssembly build of Vosk
Apache License 2.0
364 stars 60 forks source link

Build broken by kaldi repo #23

Closed Yahweasel closed 2 years ago

Yahweasel commented 2 years ago

The kaldi repo no longer has an upstream-1.8.0 branch nor a revision 75ecaef39 (thanks, git, for allowing erasing history). Right now, vosk-browser doesn't build because of these issues.

Yahweasel commented 2 years ago

Correction: The commit is still there, just the branch is gone. Now I have to remember how to git clone a specific revision...

Yahweasel commented 2 years ago

And the answer is that you can't. I don't understand why people use git when it's this awful.

Yahweasel commented 2 years ago

I made a commit to "fix" it by fetching the ZIP of the commit, but it's so awful, I'm reluctant to pull request :) . Here it is, holler if you want me to make a PR: https://github.com/ennuicastr/vosk-browser/commit/db6566ba0a9f62ed9bcd4df7b84f158996c2c9b5

ccoreilly commented 2 years ago

The branches were renamed, but I guess something got rebased because the same commit now has another hash.

As you say, the commit is still in the repo so just removing the branch reference and single-branch flag should suffice. I am testing it, otherwise I will switch to the new "vosk" branch and test. I have a local copy of the repository in the working state, I wanted to avoid forking a fork and maintaining it.

ccoreilly commented 2 years ago

Ok, I can't checkout the commit without branch and I need to update the patch to work with the new rebased commit. I pushed the local copy I had until I can change the patch to work with the official kaldi fork of alphaceph.

I'll update the builder Dockerfile once I confirm it builds again. Thank you for noticing and letting me know!

Yahweasel commented 2 years ago

Yeah, simply removing those flags would not work with the older hash. There is literally nothing you can do to get git to clone or fetch a commit that is not the antecedent of a living reference (branch or tag). It's infuriating.

I await a fix. I assure you, my interest in noticing is purely selfish :rofl:

nshmyrev commented 2 years ago

new branch is called "vosk" https://github.com/alphacep/kaldi/tree/vosk

ccoreilly commented 2 years ago

Thank you Nikolay. As a quick fix I pushed the old state to a repository in my handle, this can be used to build the library until I find the time to update the patch against the "vosk" branch. See commit.