search

ccorsano / TwitchAchievementTrackerExtension

MIT License
0 stars 0 forks source link

XAPI Key Length Restricted #46

Open djekl opened 4 months ago

djekl commented 4 months ago

Hi,

I am the developer of XAPI (formally XboxAPI). I was contacted today by a twitch streamer who wishes to use your extension. However there is a limitation of 45 chars for the API key.

These API keys are using the Laravel Framework and quickly generating one gives me a length of 48. e2yUBR6tuZ9ZzX7fthUUxBw2aKDttp39vabOzWEK144027be <-- This is a dead example key.

I would suggest that if you require to enforce a key length, then set it to at least 50.

Also, I understand that loosing the free tier wasn't good. However this was being abused by the few, causing issues for the many.

Happy to work with you on getting this updated for your users who still wish to use this project/extension.

djekl commented 4 months ago

Looking at the code, you also have 2 different limitations;

https://github.com/ccorsano/TwitchAchievementTrackerExtension/blob/master/TwitchAchievementTrackerFrontend/src/components/ConfigXBL_01_XApiKey/ConfigXBL_01_XApiKey.svelte#L101-L102

A length restriction of 45, and a pattern match of 40.

ccorsano commented 4 months ago

Hey @djekl ! Thanks for forwarding the issue, if the issue is the length limitation it looks like a quick and easy fix indeed. I'll need to revive this project and prep it for a new submission though, which might take some effort.

Also thank you for your work on XAPI, it was a blessing to find a publicly available alternative to call into XBoxLive APIs back when I started this. I can easily imagine the kind of abuse which led you to abandon the free tier, so I won't be one to judge !