search

ccoutant / dwarf-locations

2 stars 5 forks source link

copy&paste&paste #73

Open markus-metzger opened 1 year ago

markus-metzger commented 1 year ago

The section starting at https://github.com/ccoutant/dwarf-locations/blob/00e62e0f2d54f6f75ce12fb7b53eb5ba0072ce72/010-generalize-offsetting.txt#L155 is repeated.

t-tye commented 1 year ago

Which text is repeated? The text on line 155 is providing changes to the DW_OP_piece operation. The text on line 171 is providing changes to DW_OP_bit_piece. And so on.

Or is the suggestion to reword so as not to keep repeating the full explanation of where the text being updated is located when there are multiple changes in the same section? I opted to repeat the full location description just to avoid confusion since this is just a running list of changes with no larger structure to organize into changes for different sections. But I agree that this style is a bit repetitive. Suggestions?

markus-metzger commented 1 year ago

I got the line wrong. The text starting at L171 is repeated starting at L205.

t-tye commented 1 year ago

Not sure how that happened. Fixed in #78.