search

ccovey / odbc-driver

Laravel 4 ODBC Driver
28 stars 48 forks source link

Problem with ODBCDriverConnection #8

Closed alexrsg closed 10 years ago

alexrsg commented 10 years ago

I've updated the last commit and now I get a issue: Declaration of Ccovey\ODBCDriver\ODBCDriverConnectionFactory::createConnection() should be compatible with Illuminate\Database\Connectors\ConnectionFactory::createConnection($driver, PDO $connection, $database, $prefix = '', array $config = Array)

How can I fix it?

wstaples commented 10 years ago

Hi, In the file vendor/ccovey/odbc-driver-l4/src/Ccovey/ODBCDriver/ODBCDriverConnectionFactory.php

change the line: public function createConnection($driver, \PDO $connection, $database, $prefix ='', $config = null)

to read: public function createConnection($driver, \PDO $connection, $database, $prefix ='', array $config = array())

I think it was line 39

alexrsg commented 10 years ago

Thank You! I saw that at pull request section and change it! It works now!