search

ccowmu / whatistheplan.com

Reimagined Parkview LAN Party site
MIT License
5 stars 5 forks source link

Added first pass at twitch #28

Closed MosesTroyer closed 7 years ago

MosesTroyer commented 9 years ago

Adds the twitch page. All it has is the twitch stream, also changed the css to accommodate it.

dyladan commented 9 years ago

this looks mostly good but i'm wondering about https://github.com/ccowmu/whatistheplan.com/pull/28/files#diff-0515afef44d2fd6aa5703fbbe27377e4R52 where you set width 100% and height 56.25%.

  1. Why is the height such a specific number? makes me think you were developing for your screen without thinking of others.
  2. Why is the width and height not the same as in the iframe where you set it as height="378" width="620"?

good job on the test by the way

MosesTroyer commented 9 years ago

The width and height are set so that the stream is the proper size (16 / 9). Without it, the stream gets very elongated, iirc

dyladan commented 9 years ago

but 100% and 56.25% is not always the same ratio. on different screens that isn't 16x9

MosesTroyer commented 9 years ago

Hm, guess I didn’t really think about that. The twitch stream link tries to set the amount of pixels for width and height, but it didn’t work for me.

dyladan commented 9 years ago

i'll take a looksie later. there's probably an easy way to do it. If nothing else we can hardcode max-height and max-width then use media queries to scale down on smaller screens

chrissphinx commented 7 years ago

this actually got merged idk why it doesn't know that