ccp4 / DUI

CCP4 DIALS User Interface
GNU General Public License v2.0
5 stars 3 forks source link

Cleanup, reformat, fix several issues #100

Closed ndevenish closed 5 years ago

ndevenish commented 5 years ago

Here's a whole load of cleanup and quality-of-life commits

Also, a couple of minor issue fixes:

ndevenish commented 5 years ago

Oh, also, since the reformatting one is a code-touch-singularity, I'm happy to commit it as author @luisodls so that it doesn't show blame as me for the entire codebase.

dagewa commented 5 years ago

I've not looked through the voluminous diffs, but I am in favour of the bullet points as described. I have a couple of questions:

  1. What are the make_next and run_all logic paths? Is this related to the "automatic mode" of an older version of DUI?
  2. Would it be possible to provide developer instructions for DUI so that any DIALS developer can get set up quickly, including usage of Black and flake8, and whatever hoops need to be jumped through to operate alongside CCP4?

I agree that committing these changes as @luisodls makes most sense, but I imagine he will want to go through the changes in some detail in that case.

luisodls commented 5 years ago

... Yes