ccp4 / DUI

CCP4 DIALS User Interface
GNU General Public License v2.0
5 stars 3 forks source link

Handling export choice between scaled or integrated intensities #102

Closed jbeilstenedmands closed 4 years ago

jbeilstenedmands commented 5 years ago

I have been thinking about how to improve the exporting, as I saw a user not click the "output scaled intensities" button upon export for exporting scaled data, as it is not on by default.

My thoughts for improvement are have two tick boxes in the panel, 'export integrated (unscaled) intensities' and 'export scaled intensities', which are mutually exclusive (i.e. clicking one would remove a tick from the other). To determine which one is initially on, one could use a simple inspection of the current reflection table, to see if it has the column 'inverse_scale_factor', or it might be worth adding an extra 'scaled' flag to the reflection table which could be set at the end of scaling.

This could then also be used to determine the choice of name for the mtz, to address #101

dagewa commented 5 years ago

I like the idea of automatically choosing the default, however there might be circumstances where exporting the integrated intensities alongside the scaled intensities is useful. I would have two tick boxes and set the default as described, but not make them mutually exclusive.

jbeilstenedmands commented 5 years ago

This is a good point, for example for mmcif format we can export all intensity types together (although for mtz export using the command line, if I use intensity=profile+sum+scale it seems that just scaled intensities are output, but I'm not sure what dials.export should want to do in this situation)

dagewa commented 5 years ago

I think MTZ export should allow export of all three, any two, or just one intensity column as chosen by the user (with sensible column names)

ndevenish commented 5 years ago

Adding this to milestone as related to #101

dagewa commented 4 years ago

The basic problem appears fixed, though the ideas in comments are not done. Close enough though.