ccp4 / DUI

CCP4 DIALS User Interface
GNU General Public License v2.0
5 stars 3 forks source link

Not possible to select `KB` model scaling from the simple tab #184

Closed dagewa closed 2 years ago

dagewa commented 2 years ago

KB is apparently the default, because it is first in dials.scale's option list. image But dials.scale does not actually set a default in its PHIL options. As a result, if you select KB, DUI assumes you mean "do the default", so you actually get physical (at least for MX data).

dagewa commented 2 years ago

Quickest solution is probably to change the order of these so that "physical" is first: https://github.com/ccp4/DUI/blob/af231bcbd4fddb1fa19c7eb9546bca5030aac434/src/dui/simpler_param_widgets.py#L483 but in general this stuff is fragile

dagewa commented 2 years ago

That's probably the wrong solution though. Better would be to prepend a dummy "Auto" option to the list.