search

ccpem / roodmus

GNU General Public License v3.0
3 stars 0 forks source link

evaluate whether to use git submodule for pipeliner/parakeet #5

Closed JatGreer closed 2 weeks ago

JatGreer commented 10 months ago

Issue 24 from gitlab Also determine whether pypi automatically applies git submodule update --init --recursive. This https://github.com/pypa/pip/pull/577/files suggests it does. I also hope that the recrsive means that parakeet submodules are initiated and updated recurivesly so that python-multem is also found during pypi install.

JatGreer commented 10 months ago

Pypi PEP508 restricts using urls in pyproject.toml dependencies, but there are a couple of (bad looking) workarounds. Talk to ppl about best way forward

JatGreer commented 10 months ago

Default behaviour for first publishing will be that ccpem-pipeliner and parakeet need to be manually installed in addition to installation of roodmus via pypi. This needs to be reviewed if we can find a way to install the required versions of pipeliner and parakeet in an automated way

JatGreer commented 7 months ago

Suggest to test and ensure that Roodmus works without Parakeet installed. If we can get this to work, then Parakeet is only a dependency of the simulation stage/utility.

This avoids a user who only wants to do analysis needing a computer with an nvidia GPU

JatGreer commented 2 weeks ago

Current main includes python-parakeet pypi package in list of pypi installs (which may/may not require specification of CXX CUDACXX and/or FFTW env vars). Therefore need for git submodules has ended.

If people are regularly failing to install due to lack of CUDA GPU/drivers (this manifests in guanaco/python-multem packages), then we may review this.