ccpgames / ccpwgl

CCP WebGL Library
MIT License
103 stars 30 forks source link

Updated files in eve folder, minor changes to others #254

Closed cppctamber closed 6 years ago

cppctamber commented 6 years ago

src/eve

src/core

src/particle

src/curves

src/math

cppctamber commented 6 years ago

I've already converted the /core/ folder but have to confirm source of errors in my refactored eve/item/ folder before I can push it.

cppctamber commented 6 years ago

Also, do you mind if I move all the extensions, paths, contructors, and a new dynamicResources objects from the Tw2ResMan to Tw2VariableStore? It will help with reducing some dependencies and enable people to detach the resMan from a specific ccpwgl instantiation more easily and/or to introduce their own resMan (ie. for people like @Robbilie who have multiple ccpwgl_ints, and for myself when using a webworker based resMan).

regner commented 6 years ago

Might be better to break PRs like this down into smaller ones. This PR is almost impossible to review.

Robbilie commented 6 years ago

that is quite a PR :D

cppctamber commented 6 years ago

Its mostly cosmetic, don't want to burn fillipp out too quickly :3

cppctamber commented 6 years ago

@filipppavlov I'll break this down into seperate pull requests to make it easier to review