Closed sveba closed 3 years ago
Hi! Thanks for the PR. I'll try to review it today or in the weekend.
I would be fine with doing this in a second step in a separate PR. If you would be interested in doing this, I would also delay a release until we have parallelization.
Agree, but additional PR would be my choice
Thanks for the work! Do you know if you are going to work on the parallelization right away or would you like a prerelease first?
I'm leaving in vacation for 1,5 months so I would not be able to work on this for that time. After that no problem. About release: like I said, this is your baby, you can decide. I have the exporter running on my server so I'm not in a hurry. :)
Ah ok. I'll wait for a release and try to come up with something, shouldn't be too hard. Enjoy your vacation and thanks again for your contribution!
Na klar. Habe ich gerne gemacht. Wie gesagt, bin absoluter Go-Anfänger ;)
Summary
--symo.timeout
--symo.timeout
. Please take that into consideration when configuring Prometheus scrape interval--symo.enable-power-flow
,--symo.enable-archive
with default values beingtrue
. With these flags, you can also disable each API endpoint.Breaking Changes
--symo.url
flag suggested to use the full URL path like--symo.url http://symo.ip.or.hostname/solar_api/v1/GetPowerFlowRealtimeData.fcgi
previously. This has now changed to base host name only, e.g.--symo.url http://symo.ip.or.hostname
(without trailing slash)Checklist
fix
,enhancement
,documentation
,change
,breaking
,dependency
as they show up in the changelog