ccremer / fronius-exporter

Prometheus Exporter for Fronius Symo Photovoltaics
Apache License 2.0
20 stars 14 forks source link

feat: add basic auth #78

Closed Trojan295 closed 1 year ago

Trojan295 commented 2 years ago

Summary

This PR adds an option to add HTTP basic authentication to the exporter endpoint. This can be useful in case you want to secure somehow the exporter.

It also switches to gin for the HTTP server. It was easier to use the basic auth implementation from gin here.

Checklist

ccremer commented 1 year ago

Hi @Trojan295 . Is there any update here?

ccremer commented 1 year ago

I am going to close this since I haven't heard a response since the PR was opened. I'm happy to review again in a new PR.