ccremer / kubernetes-zfs-provisioner

Dynamic ZFS persistent volume provisioner for Kubernetes
Apache License 2.0
80 stars 7 forks source link

Add ReserveSpace parameter to StorageClass #103

Closed Foxite closed 1 year ago

Foxite commented 1 year ago

Summary

Checklist

For Helm Chart changes

Foxite commented 1 year ago

Do you think this requires manual testing?

ccremer commented 1 year ago

Do you think this requires manual testing?

If you like, you can add unit test in Go to see if the parameters applied are rendered correctly, see the test folder within the chart. https://github.com/ccremer/kubernetes-zfs-provisioner/blob/master/charts/kubernetes-zfs-provisioner/test/storageclass_test.go

Foxite commented 1 year ago

I just ran make chart-docs but nothing changed.

What version should I bump to?

ccremer commented 1 year ago

What version should I bump to?

Since this is a new feature, version 2.2.0 would be next https://github.com/ccremer/kubernetes-zfs-provisioner/blob/master/charts/kubernetes-zfs-provisioner/Chart.yaml

I just ran make chart-docs but nothing changed.

It should update the readme after you bump the version IIRC

Foxite commented 1 year ago

All done!

ccremer commented 1 year ago

Merged & released. Thanks for the PRs :)