Closed Foxite closed 1 year ago
Do you think this requires manual testing?
Do you think this requires manual testing?
If you like, you can add unit test in Go to see if the parameters applied are rendered correctly, see the test
folder within the chart.
https://github.com/ccremer/kubernetes-zfs-provisioner/blob/master/charts/kubernetes-zfs-provisioner/test/storageclass_test.go
I just ran make chart-docs
but nothing changed.
What version should I bump to?
What version should I bump to?
Since this is a new feature, version 2.2.0
would be next
https://github.com/ccremer/kubernetes-zfs-provisioner/blob/master/charts/kubernetes-zfs-provisioner/Chart.yaml
I just ran make chart-docs but nothing changed.
It should update the readme after you bump the version IIRC
All done!
Merged & released. Thanks for the PRs :)
Summary
Checklist
For Helm Chart changes
kind:bug
,kind:enhancement
,kind:documentation
,kind:change
,kind:breaking
,kind:dependency
as they show up in the changelogarea:chart
chart:kubernetes-zfs-provisioner
make chart-docs