Added GeoServer Support

ccri / cloud-local

Install script for a local 1 node cloud...no excuses folks

17 stars 5 forks source link

Added GeoServer Support #42

Open aheyne opened 8 years ago

aheyne commented 8 years ago

Added a command line parameter that is only read when cloud-local start is invoked. If the parameter -gs is provided and GEOSERVER_HOME is set then the script will start and stop GeoServer with the cloud. Note GeoServer runs in the current thread so ctrl+c is needed to shut it down.
Added documentation of -gs command.

Signed-off-by: Austin Heyne aheyne@ccri.com

cne1x commented 8 years ago

I like this idea, particularly since we so often want a GeoServer running, and you've decoupled the configuration of GeoServer from cloud-local. The only thing I wonder about is whether we can NOHUP the GeoServer start-up so that it runs in the background. If we could, can we make the "stop" command kill the GeoServer process, too? That might make things slightly cleaner for people, rather than tying up their terminal session. (Okay, yes: They could simply choose to NOHUP their cloud-local invocation, but let's make it easier on folks, eh?)

cne1x commented 8 years ago

[picky, picky, picky] I think your commit message meant, "invoked" rather than "envoked". I'll admit, I get "invoke" and "evoke" confused more often than most people, but we might want to tidy this up.

aheyne commented 8 years ago

So I wasn't having any luck with the NOHUP, maybe it would work somehow, but I got it working by sending GeoServer to a background process and saving the PID for shutdown.

cne1x commented 7 years ago

Can you rebase this on master, and fix conflicts, please?

aheyne commented 7 years ago

merged master

aheyne commented 7 years ago

Before merging we/I should remove the PID from the file after closing geoserver. This could accidentally kill another process with the same PID later.