ccrma / chugins

Repository for ChuGins
MIT License
115 stars 47 forks source link

NHHall and Ladspa chugins missing from osx build #70

Open heuermh opened 1 year ago

heuermh commented 1 year ago

NHHall and Ladspa chugins are present in the repo and were present in osx builds up until recently, but now are missing from the osx build. I haven't looked into this carefully yet; those are simply two that I use in LiCK and found break the build as of chuck version 1.5.0.0.

$ cd chugins
$ make osx
...
CHUCK_STRICT=1 make -C Wavetable/ osx
clang++ -mmacosx-version-min=10.9 -D__MACOSX_CORE__ -I../chuck/include/ -arch x86_64 -fPIC -O3 -Werror -c -o Wavetable.o Wavetable.cpp
clang++ -mmacosx-version-min=10.9 -shared -lc++ -arch x86_64 -o Wavetable.chug Wavetable.o

$ sudo make install
Password:
mkdir -p /usr/local/lib/chuck
cp -rf ABSaturator/ABSaturator.chug AmbPan/AmbPan.chug Bitcrusher/Bitcrusher.chug KasFilter/KasFilter.chug MagicSine/MagicSine.chug FIR/FIR.chug FoldbackSaturator/FoldbackSaturator.chug PanN/PanN.chug PitchTrack/PitchTrack.chug GVerb/GVerb.chug Mesh2D/Mesh2D.chug Spectacle/Spectacle.chug Elliptic/Elliptic.chug Sigmund/Sigmund.chug ExpDelay/ExpDelay.chug Overdrive/Overdrive.chug Multicomb/Multicomb.chug PowerADSR/PowerADSR.chug WinFuncEnv/WinFuncEnv.chug WPDiodeLadder/WPDiodeLadder.chug WPKorg35/WPKorg35.chug Binaural/Binaural.chug ExpEnv/ExpEnv.chug Perlin/Perlin.chug Random/Random.chug Wavetable/Wavetable.chug /usr/local/lib/chuck

$ cd ../lick
$ chuck --loop &
$ chuck + import.ck
...
[chuck](VM): sporking incoming shred: 1 (import.ck)...
"LiCK  Library for ChucK." :(string)
"Copyright (c) 2007-2023 held jointly by the individual authors." :(string)
"Licensed GNU General Public License (GPL), version 3 or later." :(string)
[chuck](VM): sporking incoming shred: 2 (BinaryFunction.ck)...
[chuck](VM): sporking incoming shred: 3 (BinaryPredicate.ck)...
...
[chuck](VM): sporking incoming shred: 348 (Golden.ck)...
[Hall.ck]:line(32): undefined type 'NHHall'...
[Hall.ck]:line(32): ... in declaration ...
...
[chuck](VM): sporking incoming shred: 436 (Hat.ck)...
[Ladspa.ck]:line(26): undefined type 'LADSPA'...
[Ladspa.ck]:line(26): ... in declaration ...
[Caps.ck]:line(25): undefined type 'Ladspa'...
[Caps.ck]:line(25): undefined super class 'Ladspa' in definition of class 'Caps'
...
gewang commented 1 year ago

thanks Michael for reporting this! @nshaheed and I was looking more into this; just added these back into the makefile (which should work for macOS and linux) in 60cba88, and if we can also verify building these on windows, would love to move towards getting these chugins into the distribution (testing, documentation, examples, etc.)...

gewang commented 1 year ago

update: we looked into these two chugins and tried to add them into the distribution, but decided to wait on documentation and examples (in the vein of the ckdoc format adopted in 1.5.0.0); also, our next big milestone is a BIG chugins update, with many new chugins for users and an API expansion for developers; as phase 2 we are moving towards a chuck package manager to discover, download, and organize chugins and libraries (like LiCK 💪). NHHall and Ladspa chugins is on our list for both phases!

cc @spencersalazar @nshaheed @celestebetancur @DBraun @tae1han