Raise errors on setup failure and logging with OmniAuth::Strategy::log method

ccrockett / omniauth-keycloak

Keycloak Strategy for OmniAuth.

MIT License

53 stars 42 forks source link

Closed alexpetrov closed 3 years ago

alexpetrov commented 4 years ago

Hello, @ccrockett !

Thank you for the gem and your work!

I implemented TODOs about raising errors and also added logging of setup. I use log method defined in OmniAuth::Strategy module. https://github.com/omniauth/omniauth/blob/master/lib/omniauth/strategy.rb#L162

If this PR is too big and not cohesive enough, I'll separate it into two or more PR-s. Please, let me know.

alexpetrov commented 3 years ago

Thank you, @ccrockett , for accepting my PR! :pray: