search

ccrockett / omniauth-keycloak

Keycloak Strategy for OmniAuth.
MIT License
53 stars 42 forks source link

Added base_url parameter to client_options. #20

Closed fchampreux closed 2 years ago

fchampreux commented 2 years ago

As described in issue #19 , our Keycloak authenthication servers do not include the /auth/ chunk in their URL. So I propose to pass this part to the omniauth callback as base_url parameter.

The impact is high on existing implementations, because it requires the client configuration to be updated. Thus it removes the hardcoded /auth/ url base.

I hope this proposal is useful.

ccrockett commented 2 years ago

thanks for the PR but I really don't want to break existing implementations. Also this PR needed some tests and some updates to the documentation.

So based on this PR, I've re-implemented this feature with all the above. Hope you get to try it out and it works for you.

fchampreux commented 2 years ago

Thanks a lot for turning my poor workaround into an actual and efficient solution!