ccsb-scripps / AutoDock-Vina

AutoDock Vina
http://vina.scripps.edu
Apache License 2.0
596 stars 209 forks source link

Make include guards unique #244

Open elfring opened 1 year ago

elfring commented 1 year ago

:thought_balloon: I find that an include guard like “VINA_H” is too short for the safe reuse of your header file (when it belongs to an application programming interface).

diogomart commented 1 year ago

Thanks. Do you know of an actual conflict or is it just to prevent a possible conflict?

elfring commented 1 year ago

:thought_balloon: I propose to reduce the probability for undesirable naming conflicts another bit.

:crystal_ball: Will the collaboration with C++ modules become more attractive accordingly?

diogomart commented 1 year ago

Sounds like it might be a good idea.

Is backwards compatibility a concern?

elfring commented 1 year ago

:crystal_ball: Would you prefer an other name pattern than appending a kind of UUID?