[Warlock] Spell lock

[Aasamath]

When being interrupted by a fellhunter, it is possible to cast a spell from a different magic school before the silence takes effect. If a Mage cast frostbolt while spamming blink, when interrupted the mage can still blink before getting silenced. Tried the other way around and it's no possible to do that with a mage improved counterspell. There is a chance it' normal behavior, but that seems weird.

[Klimpb]

This is a bit of a strange issue.. Many videos of TBC retail shows an extra batch delay between when the spell effect happens on the target and when the debuff itself applies. Mostly with spells that has got a trigger(interrupt, then silence for example). But it can also be seen with other spells that has not such as Psychic Scream & Frost Nova... This wasn't always the case on retail though, many footage show both scenarios. 1 being how it currently works on Corecraft for all spells(except for Spell Lock for some reason). The other being that debuffs gets applied 1 batch after the spell effect.

I'm suspecting that Shiro has implemented this mechanic but only for Spell Lock, probably something he did more than a year ago because he saw it in many videos.

Not sure if this is feature that is all that desirable.

[ccshiro]

@SuddenDeath I didn't implement that, no. This is an effect that happens by itself due to how the spell data looks.

Felhunter's spell lock is split off into two components: Part one has an interrupt effect and triggers Part two (see: http://db.vanillagaming.org/?spell=19244) Part two has the actual silenced aura (see: http://db.vanillagaming.org/?spell=24259)

This means, given our implementation, that the interrupt from Spell Lock happens prior to the actual silence spell.

Improved counterspell has a different spell setup which results in different behavior.

It's possible this is wrong, but it's also possible it isn't (after all blizzard split it off for some reason, I'd imagine).

[Klimpb]

https://youtu.be/czV-xTY6NV0?t=11m24s You'll see that the silence debuff won't appear until 35 frames after the spell got locked, however. You can also take note that when the debuff appears it has already passed about or more than 1/3 of the duration of it, this combined with him having 183ms latency it could very well just be a delay on the debuff showing, the silence effect came in when the spell got locked

https://youtu.be/LUCv1guR-zQ?t=4m54s Here you can see the same thing, he casts spell lock, then 8 frames later spell gets locked, then another 8 frames until silence debuff appear, though you can also see that the timer has already started on this debuff and looks to be about 6-8 frames into the debuff.