search

ccswbs / hjckrrh

GNU General Public License v2.0
6 stars 5 forks source link

PP1 No Pictures - Role filter does not work on submit #507

Closed mmafe closed 8 years ago

mmafe commented 8 years ago

On the PP1 No Pictures view pane, the role filter does not work when submitted. Instead of going to sitename/people?field_profile_role_tid=#, it goes to sitename?field_profile_role_tid=#.

Needed for Business client site.

tqureshi-uog commented 8 years ago

Add 140 Faces grid view to People Profiles along with other People Profile fixes

tqureshi-uog commented 8 years ago

@mmafe Is this already fixed? When I go to https://www.uoguelph.ca/business/people?field_profile_role_tid=46 the role filters work properly

mmafe commented 8 years ago

@tqureshi-uog As far as I can tell, this has not been fixed on the AODA platform.

It looks like it was fixed manually on Business (see https://www.uoguelph.ca/business/admin/structure/features/ug_profile/diff/views_view)

brharp commented 8 years ago

This may be fixed by William’s pull request:

https://github.com/ccswbs/hjckrrh/pull/524/commits/b6f068ce514cac7dad68decc05db4b549526ad5b

From: tqureshi-uog [mailto:notifications@github.com] Sent: Thursday, September 15, 2016 11:01 AM To: ccswbs/hjckrrh hjckrrh@noreply.github.com Subject: Re: [ccswbs/hjckrrh] PP1 No Pictures - Role filter does not work on submit (#507)

@mmafehttps://github.com/mmafe Is this already fixed? When I go to https://www.uoguelph.ca/business/people?field_profile_role_tid=46 the role filters work properly

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/ccswbs/hjckrrh/issues/507#issuecomment-247353992, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AB8WnY9JWknoNv5rC291Y_SB1K23GVPXks5qqV21gaJpZM4JTDbc.

brharp commented 8 years ago

Please test William’s branch and see if it fixes the problem.

From: tqureshi-uog [mailto:notifications@github.com] Sent: Thursday, September 15, 2016 11:01 AM To: ccswbs/hjckrrh hjckrrh@noreply.github.com Subject: Re: [ccswbs/hjckrrh] PP1 No Pictures - Role filter does not work on submit (#507)

@mmafehttps://github.com/mmafe Is this already fixed? When I go to https://www.uoguelph.ca/business/people?field_profile_role_tid=46 the role filters work properly

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/ccswbs/hjckrrh/issues/507#issuecomment-247353992, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AB8WnY9JWknoNv5rC291Y_SB1K23GVPXks5qqV21gaJpZM4JTDbc.

tqureshi-uog commented 8 years ago

William's fix worked, now merged with Master