No visual indicator when image-based links are in tab focus

[chyatt]

Reproducible in Chrome at least.

E.g. engineering, United Way Idol pages

[brharp]

Disabling this rule:

a:focus { outline: thin dotted; }

Seems to fix the problem in Chrome. Do we understand the problem here? Is “thin dotted” a valid value for the “outline” property? What happens if we remove the rule for “a:focus” altogether? Does anything else break?

Brent

From: chyatt [mailto:notifications@github.com] Sent: Friday, September 16, 2016 3:24 PM To: ccswbs/hjckrrh hjckrrh@noreply.github.com Subject: [ccswbs/hjckrrh] No visual indicator when image-based links are in tab focus (#536)

Reproducible in Chrome at least.

E.g. engineering, United Way Idol pages

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/ccswbs/hjckrrh/issues/536, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AB8WnThSoeCOgEkWOaycTkxtuv2KNox3ks5qquzMgaJpZM4J_Q7F.

[tqureshi-uog]

It seems this rule was added in order to force Chrome to use a dotted-line focus indicator (as opposed to its default of a thick blue border). Disabling it has no adverse effect whatsoever - FF continues to use its own default dotted line focus indicator on all links (text and images), while Chrome defaults to the blue border.

With this rule in place, Chrome outlines text links with a thin dotted line, but image links get no focus indicator. Perhaps an extra CSS rule could be added that explicitly assigns a thin dotted focus indicator to image links, but it looks like the original rule was for minor aesthetic reasons only and it's better to just let the browser defaults for focus outlines stay in place.

[brharp]

@tqureshi-uog Then please create a pull request with the rule disabled, so we can review / test the change.

[brharp]

Fixed by pull request #545.

[mmafe]

@brharp Hey Brent, has this been released yet? I'm still seeing the issue on client sites. Eg. https://aoda-client.uoguelph.ca/police

[brharp]

Merged, but not yet released.

---

From: mmafe [notifications@github.com] Sent: Thursday, October 6, 2016 5:24 PM To: ccswbs/hjckrrh Cc: Brent Harp; Mention Subject: Re: [ccswbs/hjckrrh] No visual indicator when image-based links are in tab focus (#536)

@brharphttps://github.com/brharp Hey Brent, has this been released yet? I'm still seeing the issue on client sites. Eg. https://aoda-client.uoguelph.ca/police

� You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/ccswbs/hjckrrh/issues/536#issuecomment-252093166, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AB8WnZN0CfHbCT9XK0lWPLvz4q4ymcxGks5qxWcNgaJpZM4J_Q7F.