ccswbs / hjckrrh

GNU General Public License v2.0
6 stars 5 forks source link

Notable Alumni - Area of Study filter #651

Closed ushenoyuog closed 7 years ago

ushenoyuog commented 7 years ago

CBE would like to have a filter for area of study as they used to on their old Notable alumni page . It doesnt seem like there is a ready field available that we could use. May need further discussion with Kate before this is implemented.

image

bdavey07 commented 7 years ago

The area of study element is currently in the body of a profile section. To implement this, instead of having a filter in the style of the Search for people by role filter on PP1, we could add buttons above the faces view that link to the view filtered by a keyword.

bdavey07 commented 7 years ago

First Draft

v1

What I Did

A first mockup can be found at https://aoda-web.uoguelph.ca/business/notable-alumni to make this work, I;

Notes

Would love to hear feedback and suggestions on this, especially if you know how to make that pesky gap go away

bdavey07 commented 7 years ago

Second Draft

v2

What I Changed

The work in progress site can still be found at https://aoda-web.uoguelph.ca/business/notable-alumni

Notes

Would love to hear feedback and suggestions on this, especially if you know how to make that pesky gap go away

bdavey07 commented 7 years ago

Third Draft

v3

What I Changed

The work in progress site can still be found at https://aoda-web.uoguelph.ca/business/notable-alumni

Notes

Would still love to hear feedback and suggestions on this, especially if you know how to make that pesky gap go away

bdavey07 commented 7 years ago

Fourth Draft

v4

What I Changed

The work in progress site can still be found at https://aoda-web.uoguelph.ca/business/notable-alumni

Notes

Would still love to hear feedback and suggestions on this, especially if you know how to make that pesky gap go away

bdavey07 commented 7 years ago

Notes on Integrating this Feature with Search by Last Name

bdavey07 commented 7 years ago

Change sort by area of study to filter by area of study

bdavey07 commented 7 years ago

Page title needs to change to represent the area of study

bdavey07 commented 7 years ago

Made the suggested changes from friday's demo

bdavey07 commented 7 years ago

https://aoda-web.uoguelph.ca/business/notable-alumni

nevantan commented 7 years ago

base.css:99

mmafe commented 7 years ago

If you remove the paragraph element from each list item, we can get rid of the slight dip that happens when you hover over the buttons.

Instead of:

<li>
    <p><a class="btn btn-primary" href="/business/notable-alumni">All</a></p>
</li>

We go with:

<li>
    <a class="btn btn-primary" href="/business/notable-alumni">All</a>
</li>