search

cct-datascience / AFS_database_code

Code for app to display standardized fish data in North America
https://viz.datascience.arizona.edu/afs-standard-fish-data/
BSD 2-Clause "Simplified" License
1 stars 3 forks source link

Add code or comment for downloading .shp file #10

Closed Aariq closed 3 months ago

Aariq commented 1 year ago

I couldn't run the app because the ecoregions shapefile isn't on GitHub. Either add code or a comment about where to download it and where to put it for better reproducibility. I think this is it: https://gaftp.epa.gov/EPADataCommons/ORD/Ecoregions/cec_na/na_cec_eco_l1.zip

erinetracy commented 1 year ago

Hi Eric,

Thank you for bringing this to my attention! I actually have been working with some IT people to make improvements on the Shiny app which will hopefully be up and running soon but I will make sure all the code is updated on github to include the ecoregions. Thanks again for letting me know!

On Fri, May 19, 2023 at 1:09 PM Eric R. Scott @.***> wrote:

I couldn't run the app because the ecoregions shapefile isn't on GitHub. Either add code or a comment about where to download it and where to put it for better reproducibility. I think this is it: https://gaftp.epa.gov/EPADataCommons/ORD/Ecoregions/cec_na/na_cec_eco_l1.zip

— Reply to this email directly, view it on GitHub https://github.com/erinetracy/AFS_database_code/issues/10, or unsubscribe https://github.com/notifications/unsubscribe-auth/AS3S4MJUK3UZYG42DW3QVVLXG7HRJANCNFSM6AAAAAAYIGEZ7M . You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- Erin Tracy

KristinaRiemer commented 1 year ago

I cleaned up the code for downloading the ecoregions data in this script in the repo, hopefully that is sufficient!

Aariq commented 1 year ago

That script works like a charm, but I still can't run the app because Lat_long_AFSshiny_012023.csv is missing I think? (or not where the code expects it to be)

KristinaRiemer commented 3 months ago

Just now coming back to this. You are right that the app cannot be run from everything in the GitHub repo. That csv has location data for bodies of water, which we don't want to make public. I will add a note about that in the README!

Aariq commented 3 months ago

Depending on priorities, it might be cool to include a dummy dataset in its place. That would be useful if a goal is for other researchers to be able to replicate this shiny app. If that's not a top priority, then I think a note in the README is fine.