cct-datascience / AFS_database_code

Code for app to display standardized fish data in North America
https://viz.datascience.arizona.edu/afs-standard-fish-data/
BSD 2-Clause "Simplified" License
1 stars 3 forks source link

Code review - small suggested changes #17

Closed diazrenata closed 1 year ago

diazrenata commented 1 year ago

name: Pull Request about: Code review title: Pull Request labels: 'pull request' assignees: '@KristinaRiemer'

Code review notes

I've gone over the app and the code that runs the app (and left the no-longer-used scripts in analysis-scripts alone). This PR includes review notes (review-notes.md) and a couple of small suggested changes to (1) the user-facing in-app documentation and (2) the files in the repo to allow the app to run locally without sensitive location data available.

As I was reading through the app code, I added comments and moved some chunks around so that the code underlying different sections of the app is grouped together. That makes no changes to functionality, but, because moving code around creates really big diffs that obscure smaller changes, I'm putting those changes in a separate branch.