search

cct-datascience / ed2-mandifore

PEcAn.ED2 runs using MANDIFORE site, patch, cohort, and met data
0 stars 1 forks source link

Figure out what to do about PEcAn breaking allometry equations #28

Closed Aariq closed 1 year ago

Aariq commented 1 year ago

Currently PEcAn overwrites ED2 defaults with its own defaults resulting in errored runs.

The simplest fix is to just turn off this behavior from PEcAn and let ED2 use it's own defaults, but this will never be merged into the develop branch.

  1. Keep a fork/branch that we install PEcAn.ED2 from
  2. Try to fix PEcAn.ED2 in a less invasive way:
    • re-name ED2IN.r2.2.0.github to ED2IN.rgit so history.rgit is used for defaults
    • possibly edit ED2IN to use ED 2.2.0 defaults for everything (i.e. IMETRAD, IALLOM and ISTRUCT_GROWTH_SCHEME) (compare with what other ED2IN files in inst/ do)
    • update suspected bad values in history.rgit
Aariq commented 1 year ago

Not going to fix PEcAn.ED2 this time. We'll install from PR https://github.com/PecanProject/pecan/pull/3125