Closed graeme-winter closed 5 years ago
Ooh, just back for the new year and immediately tripped over the missing mrcfile dependency. I like Graeme's suggestion. Happy to do the leg-work if it's considered desirable but too low a priority for your immediate to-do lists.
Running the following will fix the immediate issue without requiring a full bootstrap build:
$ libtbx.pip install mrcfile
However, wouldn't it be better to make use of the libtbx.pkg_utils dependency feature to ensure dependency updates are handled transparently?
https://github.com/cctbx/cctbx_project/blob/master/libtbx/pkg_utils.py
E.g.: https://github.com/dials/dials/blob/master/libtbx_refresh.py#L25
Adding something like the following to iotbx/libtbx_refresh.py would ensure the correct version of mrcfile is installed:
import libtbx.pkg_utils
libtbx.pkg_utils.require('mrcfile', '>=1.1.0')
This could be helped with the pull request from @ndevenish https://github.com/cctbx/cctbx_project/pull/290
This should be solved now. Thanks to @ndevenish we have libtbx.show_python_dependencies
to check if everything is fine and make reconf
updates theses things automagically.
assuming the dependencies are correctly declared in iotbx/libtbx_config, which they are not. Different issue though.
i.e. mrcfile recently became a new dependency so now
wouldn't it be nice if the libtbx.refresh warned me that a new dependency was added?