search

cctbx / cctbx_project

Computational Crystallography Toolbox
https://cci.lbl.gov/docs/cctbx
Other
208 stars 111 forks source link

cbflib dependency #299

Open pcxod opened 5 years ago

pcxod commented 5 years ago

This is related to #201 but with a bit more details. First of all the library cannot be built with newer that VS2008 (over 10 years old!) compilers on Windows, then the problem comes with it when the one wants to have a debug cctbx build (Windows related again) but without debug Python build - it is easy to trick other modules with a copy of python27.lib as python27_d.lib, but not this one as it does require some debug built procedures with the specific suffix... By simply deleting the module folder and re-configuring (in my case iotbx smtbx fast_linalg) - this does the job. This also helps with just compiling cctbx with let's say VS 2017 - issue #300. Is there a better way?

pcxod commented 5 years ago

Also, basically - why is it in by default?

graeme-winter commented 5 years ago

Same as a why a bunch of other dependencies are in there by default - we don't have a really flexible way to control them - mrcfile, biopython, ...

hdf5 was made optional because somehow that was specially bad...

but then I see things like

# skip unnecessary base packages when building phaser only

in bootstrap so ... ¯_(ツ)_/¯