boost_adaptbx/tests/tst_python_streambuf.py failing on python 3

Anthchirp commented 5 years ago

loads of tests still failing on python 3. This one is run by azure: https://dev.azure.com/cctbx/cctbx_project/_build/results?buildId=184

  Standard error:
    Traceback (most recent call last):
      File "/__w/1/modules/cctbx_project/boost_adaptbx/tests/tst_python_streambuf.py", line 7, in <module>
        import StringIO
    ModuleNotFoundError: No module named 'StringIO'

Looks like this test was never run during porting to Python3?

nksauter commented 5 years ago

Intentional. Aaron mentioned that he would take care of this test downstream, in the commit message. Nick

Nicholas K. Sauter, Ph. D. Senior Scientist, Molecular Biophysics & Integrated Bioimaging Division Lawrence Berkeley National Laboratory 1 Cyclotron Rd., Bldg. 33R0345 Berkeley, CA 94720 (510) 486-5713

On Tue, Jul 9, 2019 at 1:59 AM Markus Gerstel notifications@github.com wrote:

loads of tests still failing on python 3. This one is run by azure: https://dev.azure.com/cctbx/cctbx_project/_build/results?buildId=184

Standard error: Traceback (most recent call last): File "/__w/1/modules/cctbx_project/boost_adaptbx/tests/tst_python_streambuf.py", line 7, in import StringIO ModuleNotFoundError: No module named 'StringIO'

Looks like this test was never run during porting to Python3?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/cctbx/cctbx_project/issues/367?email_source=notifications&email_token=ADQ24VRFDLZ5FTITTKHGSQ3P6RHMJA5CNFSM4H7DHFGKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G6BL6QA, or mute the thread https://github.com/notifications/unsubscribe-auth/ADQ24VQQQ4PNX5K2NUB3LETP6RHMJANCNFSM4H7DHFGA .

graeme-winter commented 5 years ago

Since @nksauter mentioned @phyy-nx on the case, assigned.

Possibly if the failure is intentional we could disable the test (since cannot mark as xfail) until the failure becomes not intended?

cctbx / cctbx_project

boost_adaptbx/tests/tst_python_streambuf.py failing on python 3 #367