cctbx / cctbx_project

Computational Crystallography Toolbox
https://cci.lbl.gov/docs/cctbx
Other
223 stars 119 forks source link

Clipper updates for C++11 #379

Open bkpoon opened 5 years ago

bkpoon commented 5 years ago

As part of making CCTBX-based software compile with C++11, it looks like we need to update our checkout of clipper to the latest version.

http://www.ysbl.york.ac.uk/~cowtan/clipper/clipper.html

As a side note, is this a feature that is widely used? If not, we can disable the downloading of the clipper source files.

vdbedem commented 5 years ago

Hi Billy,

Thanks. qFit v1.0 and 2.0 rely on clipper, as does Xpleo. It would be great if the clipper source files remained available.

Thanks!

H

bkpoon commented 5 years ago

@vdbedem Alright, do you know if your code works with the latest version of Clipper from CCP4? I can update our version to revision 354 from the official repository, which was lasted changed on 2019-03-22.

pafonine commented 5 years ago

Also, I'm curious what exactly functionality of Clipper you use (just in case it can be seamlessly replaced with analogous one from CCTBX, if available)?

Pavel

On 8/13/19 09:30, Billy K. Poon wrote:

@vdbedem https://github.com/vdbedem Alright, do you know if your code works with the latest version of Clipper from CCP4? I can update our version to revision 354 from the official repository, which was lasted changed on 2019-03-22.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/cctbx/cctbx_project/issues/379?email_source=notifications&email_token=AD3GE2OFVXQXDY6LVSG4DJDQELORFA5CNFSM4ILF5FZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4GG6EQ#issuecomment-520908562, or mute the thread https://github.com/notifications/unsubscribe-auth/AD3GE2MRSOW7TBZ7H7LXMRTQELORFANCNFSM4ILF5FZQ.