cctbx / dxtbx

Diffraction Experiment Toolbox
BSD 3-Clause "New" or "Revised" License
2 stars 18 forks source link

Encoding panel information in dxtbx #167

Open graeme-winter opened 4 years ago

graeme-winter commented 4 years ago

Many detectors are constructed from modules, with "dead pixels" in the gaps (thinking of Eiger and Pilatus in particular here) - we have the structure of these detectors encoded all over the place for defining e.g. the mask regions and such like.

There are however good arguments for properly encoding the structure e.g. to allow calculations to be split across independent modules - without necessarily splitting the data array. Suggestion is along the lines of defining some non-overlapping regions of the panel which corresponds to individual modules, probably as pixel ranges since everything else can be derived from this.

rjgildea commented 4 years ago

I think https://github.com/cctbx/dxtbx/issues/17 would be related here - or at least could be solved along the way.

graeme-winter commented 4 years ago

@rjgildea agreed, good point.