search

cctbx / dxtbx

Diffraction Experiment Toolbox
BSD 3-Clause "New" or "Revised" License
2 stars 18 forks source link

`FormatMRC`: more robust handling of extended headers. #679

Closed dagewa closed 8 months ago

dagewa commented 8 months ago
  1. Extended headers with padding are now supported in mrcfile>=1.5.0 (https://github.com/ccpem/mrcfile/issues/50). For older versions of mrcfile just ignore the extended header.
  2. The only example of a padded extended header I've seen actually contained useless values anyway (with a zero pixel spacing). In this case, also ignore the extended header.
codecov[bot] commented 8 months ago

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (dbd7ede) 42.62% compared to head (5caded7) 42.61%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #679 +/- ## ========================================== - Coverage 42.62% 42.61% -0.01% ========================================== Files 182 182 Lines 15924 15932 +8 Branches 3056 3057 +1 ========================================== + Hits 6788 6790 +2 - Misses 8510 8515 +5 - Partials 626 627 +1 ```