search

cctbx / dxtbx

Diffraction Experiment Toolbox
BSD 3-Clause "New" or "Revised" License
2 stars 18 forks source link

NXmx bugs #692

Open phyy-nx opened 7 months ago

phyy-nx commented 7 months ago

1)

https://github.com/cctbx/dxtbx/blob/51794204be6b849561464dfbbc72088d6c6d7208/src/dxtbx/format/nexus.py#L744-L746

equipment_component is optional, so parent.attrs["equipment_component"] could fail.

2)

https://github.com/cctbx/dxtbx/blob/51794204be6b849561464dfbbc72088d6c6d7208/src/dxtbx/format/nexus.py#L1045-L1046

Hardcoded units instead of reading the units