search

cctbx / dxtbx

Diffraction Experiment Toolbox
BSD 3-Clause "New" or "Revised" License
2 stars 12 forks source link

Add natural sorting #697

Closed graeme-winter closed 4 months ago

graeme-winter commented 4 months ago

This will allow dials.import to behave as a user would expect, as it naturally sorts rather than strictly sorts input values (i.e. 2 comes before 11)

Fixes dials/dials#2302

This adds a dependency on natsort which is available on conda but we don't have conda dependencies listed for dxtbx so that will be a separate PR

ndevenish commented 4 months ago

Technically we have .azure-pipelines/ci-conda-env.txt which is used by the CI. But we probably do need to separate out dxtbx dependencies more formally.

graeme-winter commented 4 months ago

Technically we have .azure-pipelines/ci-conda-env.txt which is used by the CI. But we probably do need to separate out dxtbx dependencies more formally.

Yes, I saw that: now added so that the CI build may work

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (e684c41) 42.44% compared to head (8ad0797) 42.44%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #697 +/- ## ======================================= Coverage 42.44% 42.44% ======================================= Files 186 186 Lines 16408 16409 +1 Branches 3141 3141 ======================================= + Hits 6964 6965 +1 Misses 8805 8805 Partials 639 639 ```