search

cctbx / dxtbx

Diffraction Experiment Toolbox
BSD 3-Clause "New" or "Revised" License
2 stars 12 forks source link

Allow distance override for multi-panel detectors #698

Closed dagewa closed 4 months ago

dagewa commented 4 months ago

Previously distance overrides in dials.import were restricted to single panel detectors by assert len(detector) == 1. This PR lifts that restriction. If a multi-panel detector has a hierarchy it will have its root node distance set. If there is no hierarchy then each panel will individually have distance set, but only if those panels are coplanar and already at the same distance.

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 0% with 23 lines in your changes are missing coverage. Please review.

Project coverage is 42.41%. Comparing base (f901366) to head (40fe02c). Report is 3 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #698 +/- ## ========================================== + Coverage 42.39% 42.41% +0.01% ========================================== Files 186 186 Lines 16362 16423 +61 Branches 3121 3145 +24 ========================================== + Hits 6937 6965 +28 - Misses 8793 8819 +26 - Partials 632 639 +7 ```