search

cctbx / dxtbx

Diffraction Experiment Toolbox
BSD 3-Clause "New" or "Revised" License
2 stars 12 forks source link

Set distance for single panel detectors with hierarchy #699

Closed dagewa closed 4 months ago

dagewa commented 4 months ago

The xia2 tests show that single panel detectors can have a hierarchy too! (Why?!) In such cases it seems that hierarchy is useless, and has origin at (0,0,0).

When we have a single panel, ensure that it is the panel itself that has its distance updated. Only change the hierarchy for multi-panel detectors, where it is assumed that it has a sensible origin.

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 42.42%. Comparing base (8f53e56) to head (babbcc3).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #699 +/- ## ========================================== + Coverage 42.41% 42.42% +0.01% ========================================== Files 186 186 Lines 16423 16417 -6 Branches 3145 3146 +1 ========================================== Hits 6965 6965 + Misses 8819 8813 -6 Partials 639 639 ```
jbeilstenedmands commented 4 months ago

Thanks, confirmed this fixes the xia2 test failure.