search

cctbx / dxtbx

Diffraction Experiment Toolbox
BSD 3-Clause "New" or "Revised" License
2 stars 18 forks source link

`FormatSMVADSCmlfsom` is too promiscuous #706

Closed dagewa closed 6 months ago

dagewa commented 7 months ago

This format is picked up in any case that an SMV file does not have TIME and DATE lines!

https://github.com/cctbx/dxtbx/blob/7964d4bd4171b1b7b8bbb70719c11d79b18d0fbd/src/dxtbx/format/FormatSMVADSCmlfsom.py#L12-L23

Unfortunately that means I am hitting it with MicroED data sent to me by users.

This class also seems to do almost nothing. I will see if I can add the support for MLFSOM images into the FormatSMVADSC base class and then delete this one.

dagewa commented 6 months ago

Note, this format class reads an old MLFSOM image in dials_regression/image_examples/MLFSOM_simulation/fake_00001.img, but actually more recent MLFSOM images have the header item BEAMLINE=FAKE. There is another format class, FormatSMVJHSim that is intended to read those images, but fails to because it is case sensitive and only checks BEAMLINE=fake